search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

Add more extensive tests #59

Closed cfergeau closed 5 months ago

cfergeau commented 1 year ago

vfkit has some unit tests, but there are no tests starting a VM and checking the VM has the expected devices. https://github.com/Code-Hex/vz makes use of https://github.com/Code-Hex/puipui-linux to start a very small VM and get a shell into the VM. vfkit could reuse this to implement various tests (check lspci output, test file sharing, test vsock listen and connect, ...) to catch regressions early. https://github.com/cfergeau/vfkit/tree/puipui/ has code which downloads puipui, starts a VM and shuts it down through ssh. We can build on that to add more useful tests.

cfergeau commented 5 months ago

This was done in https://github.com/crc-org/vfkit/pull/61 The tests for VM devices could be made even more extensive, but these will be good enough for now, let's close this.