search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

Improve "is kernel compressed" check #60

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

ARM64 kernels must be uncompressed before they can be booted. vfkit has a check for this to warn the user before attempting to start the VM. However this check has both false negatives and false positives (with an uncompressed puipui linux kernel, and with a compressed fedora kernel)

This PR should fix both situations

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 1 year ago

CI is failing as part of linter.

cfergeau commented 1 year ago

CI is failing as part of linter.

Fixed now!