Closed cfergeau closed 7 months ago
one thing i noticed is that the tests are downloading the puipui linux tarball multiple times (one download for each test scenario) which is fine since it is very small in size, but if we do test fedora or some other real distro we need to implement OSProvider to download the image only once
/hold added a commit to try to understand why gh actions don't behave as I expect them to.
/unhold hopefully should be good this time. Tests can run/succeed on macos 12/13, and are skipped on macos 11
one thing i noticed is that the tests are downloading the puipui linux tarball multiple times (one download for each test scenario) which is fine since it is very small in size, but if we do test fedora or some other real distro we need to implement OSProvider to download the image only once
Yep, this definitely needs improvements :)
/lgtm /approve
/lgtm
/lgtm
/approve
/approve
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anjannath, cfergeau, praveenkumar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This reuses the puipui linux work from Code-Hex/vz. The OS is abstracted with a OSProvider interface which will hopefully be implementable with Fedora CoreOS or other distros.
Tests which are currently implemented: