crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

tests: Add basic e2e test #61

Closed cfergeau closed 7 months ago

cfergeau commented 1 year ago

This reuses the puipui linux work from Code-Hex/vz. The OS is abstracted with a OSProvider interface which will hopefully be implementable with Fedora CoreOS or other distros.

Tests which are currently implemented:

anjannath commented 7 months ago

one thing i noticed is that the tests are downloading the puipui linux tarball multiple times (one download for each test scenario) which is fine since it is very small in size, but if we do test fedora or some other real distro we need to implement OSProvider to download the image only once

cfergeau commented 7 months ago

/hold added a commit to try to understand why gh actions don't behave as I expect them to.

cfergeau commented 7 months ago

/unhold hopefully should be good this time. Tests can run/succeed on macos 12/13, and are skipped on macos 11

cfergeau commented 7 months ago

one thing i noticed is that the tests are downloading the puipui linux tarball multiple times (one download for each test scenario) which is fine since it is very small in size, but if we do test fedora or some other real distro we need to implement OSProvider to download the image only once

Yep, this definitely needs improvements :)

anjannath commented 7 months ago

/lgtm /approve

anjannath commented 7 months ago

/lgtm

praveenkumar commented 7 months ago

/lgtm

praveenkumar commented 7 months ago

/approve

cfergeau commented 7 months ago

/approve

cfergeau commented 7 months ago

/approve

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath, cfergeau, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment