crc-org / vfkit

Apache License 2.0
119 stars 23 forks source link

Generate vfkit version from git tag #69

Closed cfergeau closed 7 months ago

cfergeau commented 9 months ago

Currently the vfkit version must be manually set before making a release, which is error-prone (this was the reason for the 0.1.1 release). This PR generates it from git tags instead using git describe. It also uses some git-archive magic to set the proper version when a tarball is used for building vfkit.

cfergeau commented 7 months ago

I added the missing file. This also needs slightly more work when building in github actions, see https://github.com/containers/gvisor-tap-vsock/pull/314/commits/cf2df8904fa55a771609319780a8f404b812d54a

anjannath commented 7 months ago

I added the missing file. This also needs slightly more work when building in github actions, see containers/gvisor-tap-vsock@cf2df89

so on github actions job we have to manually fetch the tags, thing to remember for when we add a automatic release job to this repo

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anjannath Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 7 months ago

New changes are detected. LGTM label has been removed.

cfergeau commented 7 months ago

I added the missing file. This also needs slightly more work when building in github actions, see containers/gvisor-tap-vsock@cf2df89

so on github actions job we have to manually fetch the tags, thing to remember for when we add a automatic release job to this repo

I've now adjusted the gh actions workflows to have proper release information on tag pushes and on git builds.

praveenkumar commented 7 months ago

/lgtm /approve