Closed BlackHole1 closed 7 months ago
Hi @BlackHole1. Thanks for your PR.
I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cfergeau
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@cfergeau take this after this week's meeting, or let us test this as part of the other changes?
In previous implementations, there was a need to maintain a timeout error variable to ignore while waiting for the VM to stop. This part of the code was not intuitive enough, and other maintainers couldn’t grasp its intention at first glance. This improvement has optimized the
waitForVMState
function by adding a timeout parameter, making the code more intuitive.