search

crc-org / vfkit

Apache License 2.0
119 stars 23 forks source link

refactor: improve code for wait vm to reach the specified state #75

Closed BlackHole1 closed 7 months ago

BlackHole1 commented 8 months ago

In previous implementations, there was a need to maintain a timeout error variable to ignore while waiting for the VM to stop. This part of the code was not intuitive enough, and other maintainers couldn’t grasp its intention at first glance. This improvement has optimized the waitForVMState function by adding a timeout parameter, making the code more intuitive.

openshift-ci[bot] commented 8 months ago

Hi @BlackHole1. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gbraad commented 8 months ago

/ok-to-test

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gbraad commented 7 months ago

@cfergeau take this after this week's meeting, or let us test this as part of the other changes?