Closed cgwalters closed 7 months ago
Hi @cgwalters. Thanks for your PR.
I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Tested this e2e in concert with https://github.com/containers/podman/pull/21208 and I am also not seeing any corruption.
/ok-to-test
the NVME device is only supported on macOS 14, so this would error on 13.
Your fixup LGTM
/lgtm /approve /hold (holding this to leave time for the tests to run)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cfergeau
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Interestingly, Apple recommends using virtio-blk https://developer.apple.com/videos/play/wwdc2023/10007/?time=630 They describe NVMe as a fallback for linux VM images which don't have the virtio-blk module built-in, and need an alternative way to access the disk data.
This also seems to avoid the disk corruption that we see with virtio-blk; it reportedly has a small performance hit for raw speed, but I think avoiding the double caching (guest and host) is much better from a performance perspective.