crccheck / docker-hello-world

Hello World web server in under 2 MB
https://hub.docker.com/r/crccheck/hello-world/
161 stars 161 forks source link

Add logging #20

Closed gitshawn closed 3 years ago

gitshawn commented 3 years ago

The container is totally silent, I think most would expect / want some logs. This PR enables minimal logs

crccheck commented 3 years ago

excellent, thanks

crccheck commented 3 years ago

well I hope Docker Hub built this! I haven't checked their UI since they turned off automated builds and the latest build is either 20 minutes old or 2 months old. And I don't see a button to manually build.

gitshawn commented 3 years ago

OK this was all news to me! I logged in to Docker Hub and cannot find a build button, that is shameful! Looks like someone will need to build a github action perhaps? https://docs.github.com/en/actions/guides/publishing-docker-images

On Wed, Sep 15, 2021 at 12:20 PM Chris Chang @.***> wrote:

well I hope Docker Hub built this! I haven't checked their UI since they turned off automated builds and the latest build is either 20 minutes old or 2 months old. And I don't see a button to manually build.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crccheck/docker-hello-world/pull/20#issuecomment-920162612, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA27HLZE3CBXEJIFAKK254LUCDBC5ANCNFSM5EBDTBBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Thanks, Shawn Friedel My LinkedIn Profile https://www.linkedin.com/in/shawnfriedel