search

crccheck / kinesis-streams

AWS Kinesis readable and writable streams
Apache License 2.0
8 stars 6 forks source link

add restartOnClose feature #42

Closed technicallyfeasible closed 5 years ago

technicallyfeasible commented 5 years ago

to get new shards once all current shards were closed also keep reading from shards if retryable errors are thrown

crccheck commented 5 years ago

what if no new shards were made but we keep re-trying? Is that user error or something the code should be smart about?

technicallyfeasible commented 5 years ago

I believe right now this will stop trying when scaling down to 0 shards. Maybe it's something that should be handled?

crccheck commented 5 years ago

yeah this seems safe to merge and we can burn that bridge when we get to it. It'll define what the test case should look like at least.