better text support - Githubissues

mattydoincode commented 9 years ago

Reason for PR

In ie8, text was appearing as the word "undefined" regardless of the content of the text element. So for example:

<text font-family="'HelveticaNeue-Medium'" font-size="4.2491">SPEED</text>

In a modern browser, this showed up as SPEED but in ie8 it showed up as undefined.

Solution

A simple change to support where the text was showing up on the elShape object in ie8 vs in chrome, etc. In chrome it was in the property text, or textContent, but in ie8, it was in the properties innerText and outerText. Pretty simple fix.

Additional Test Case

I added a more full featured test case of a speed limit sign to show that the text now works (you'd have to test in ie8 though, which I doubt anyone but me is doing at the moment).

crccheck commented 9 years ago

Sweet, thanks for catching this. I'll get it in later today.

crccheck commented 9 years ago

There's some very minor things, but it looks good to me +1

the viewbox on the svg makes it so the original svg is teeny tiny so it doesn't match the scale of the raphael version
there's some extra attributes that aren't related to the tests, I think they might distract some. I'd remove them.

I'm planning on merging this when I get home in an hour as is. They're my own personal stylistic preferences.

crccheck / raphael-svg-import-classic

better text support #25

Reason for PR

Solution

Additional Test Case