search

crccheck / raphael-svg-import-classic

Import SVG files to Raphael
MIT License
98 stars 40 forks source link

Unexpected test case failures in IE #4

Open crccheck opened 12 years ago

crccheck commented 12 years ago

Using IE8, viewing the test cases shows a lot of failures. A lot of them should still work, even with some degradation. Maybe add markup for pure Raphaeljs implementation of the same test cases to make sure whether or not it's this script or Raphaeljs not working.

tylerault commented 10 years ago

I noticed that IE8 throws an error when an id is duplicated, which happens when a group ("g" tag) has an id. The script tries to pass the id on to the first child. In my case I just changed this attribute name, but you may want to do one of the following:

crccheck commented 10 years ago

ah thanks. the current logic is designed specifically for a particular adobe illustrator -> svg conversion. How was your svg generated?

tylerault commented 10 years ago

With many curse words. Flash file with symbols distributed to named layers; exported as Adobe FXP; opened in Adobe Illustrator with layers; exported as SVG 1.0; some manual search-replacing. Final structure is some groups with ids (where layers contained multiple paths or polygons) as well as just polygons with ids.

IDs should be unique, but I've never known browsers to actually throw an error until this.

crccheck commented 10 years ago

I saw @RReverser has been a lot of good thing in his branch. I'm going to try and improve testing before I start mucking around in this again because I don't really remember what I did in the first place :whale:.

RReverser commented 10 years ago

I'll send you a pull request on Monday with own improvements if you wish.

From: crccheck Sent: 03.08.2013 23:36 To: crccheck/raphael-svg-import-classic Cc: Ingvar Stepanyan Subject: Re: [raphael-svg-import-classic] Unexpected test case failures in IE (#4)

I saw @RReverser has been a lot of good thing in his branch. I'm going to try and improve testing before I start mucking around in this again because I don't really remember what I did in the first place :whale:.

Reply to this email directly or view it on GitHub: https://github.com/crccheck/raphael-svg-import-classic/issues/4#issuecomment-22061181