search

crcollins / pyOS

A simple pure Python OS.
44 stars 12 forks source link

2to3 migration fail #4

Open Hierosme opened 2 years ago

Hierosme commented 2 years ago

Hello,

i have try to port pyOS to Python3 and i repport here what have happem

After have use 2to3 the System have a trouble with the imp module. Unfortunally the imp is deprecated and should be replace by importlib unfortunally the function source_load dont exist anymore in importlib

Actually i have pyOS as target because i prepare a similar project for MicroPython. Any assistance will be apprecied. (Python skill is not a trouble, how refactor is my mind)

For me pyOS should be migrate to SetupTools setup.py, and directory should be use as subModule. (i can deal easlly with that). A second thing. Setuptools permit to use console_script and be a good candidat for create one entrypoint by program

Thanks for you work, look nothing but the way for Micropython look inside you work.

Regards

crcollins commented 2 years ago

Hey, thanks for starting a Python 3 port for this. Yes, I agree setting up something like setup.py would be a good idea here. At the time this was written, it was all just a hack to tinker with things. So, that kind of expansion was outside the scope of what I was doing.

Feel free to send another PR with the changes needed for setting up setup.py.

Prithwis-2023 commented 1 year ago

by the way, I have edited the code and now it runs in python 3 as well!

Hierosme commented 1 year ago

Hi,

Have you publish the code somewhere else ?

In tht case my previus PR about Python3 port should be close

Prithwis-2023 commented 1 year ago

I have created a fork of the project. Will post it here

On Wed, Aug 16, 2023 at 11:59 PM Hierosme @.***> wrote:

Hi,

Have you publish the code somewhere else ?

In tht case my previus PR about Python3 port should be close

— Reply to this email directly, view it on GitHub https://github.com/crcollins/pyOS/issues/4#issuecomment-1681733770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFQFP3XC3VKKG4WPW4PCE3XVW6NZANCNFSM5SRZCYNQ . You are receiving this because you commented.Message ID: @.***>

-- Regards, Prithwis Whatsapp : +91 7044066618

Prithwis-2023 commented 1 year ago

https://github.com/Prithwis-2023/pyOS

Hierosme commented 1 year ago

Ok thank, then i'll wait for the big merge.

Prithwis-2023 commented 1 year ago

May I have your email? Want to discuss about this project.

On Thu, Aug 17, 2023, 1:29 PM Hierosme @.***> wrote:

Ok thank, then i'll wait for the big merge.

— Reply to this email directly, view it on GitHub https://github.com/crcollins/pyOS/issues/4#issuecomment-1681818848, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFQFP3BDBMU5WXXBAT6TK3XVXFPBANCNFSM5SRZCYNQ . You are receiving this because you commented.Message ID: @.***>