search

crcresearch / smartcontainers

Smart Containers to track Provenance in a Docker ecosystem
http://daspos.org
Apache License 2.0
5 stars 3 forks source link

Parse dockerfile commands #42

Closed ghost closed 8 years ago

ghost commented 8 years ago

This PR includes initial parsing and tests for most of the Dockerfile build commands (I can add support for the missing few to this PR or in a later PR).

The tests are a bit 'wordy': more specifically, I could probably clean them up to include less repeated code (Instead of build_processor.PU.data, I could store that in a variable data to reuse throughout the tests).

Anyways, I guess that's the nice part of the PR workflow: code review :)

Feel free to suggest enhancements, things I missed, things you'd like to see included in this or another PR, and any other feedback. I'm still learning about the overall project, so I am looking to learn as much about it as possible.

Thanks.

ghost commented 8 years ago

Minor update.

ghost commented 8 years ago

I went ahead and refactored the overall structure of the build processing test cases.