search

crdroidandroid / issue_tracker

all crDroid related issues should go here
12 stars 1 forks source link

Monet Theming Engine Regresion #160

Closed KoremuMekuro closed 1 year ago

KoremuMekuro commented 1 year ago

With 9.3, firstly on redmi note 8t and then on poco f3 with second 9.3 update I noticed that monet theming options was changed and I can't have anymore vibrant colors.Only with proprietary repainter I can achive vibrant colors.Why that was changed?Is there any hope that old theming option will be returned?Or maybe there will be added options, so it will be possible to achive vibrant colors?

neobuddy89 commented 1 year ago

This was fixed recently. https://github.com/crdroidandroid/android_frameworks_base/commit/04ffb02a43ec7b86ace2dc9ca18dfc8bf51e4edf https://github.com/crdroidandroid/android_packages_apps_crDroidSettings/commit/527c54c64ee3f00b45fc029d14baf55b8cb83924

KoremuMekuro commented 1 year ago

This was fixed recently. crdroidandroid/android_frameworks_base@04ffb02 crdroidandroid/android_packages_apps_crDroidSettings@527c54c

This wasn't fixed.On poco f3 update was only a day ago.And in the commit there are still the same options from this 9.3 update and not from march 31st 9.3 or 9.2 and earlier.Or maybe I have to downgrade and show that settings are changed and that they are producing bad results in dark mode.This commits are exactly why I opened this issue.It's cuz of them.It's cuz before them all was fine. Screenshot_20230407-192142_Settings

neobuddy89 commented 1 year ago

@KoremuMekuro what is issue on poco f3 you facing

KoremuMekuro commented 1 year ago

@KoremuMekuro what is issue on poco f3 you facing

Issue is the 'new' monet theming options.This 'new' options are producing bad results in dark mode as opposed to march 31st 9.3 build and erlier, on which there was older monet theming options that dosen't have such problem. crdroidandroid/android_frameworks_base@04ffb02 crdroidandroid/android_packages_apps_crDroidSettings@527c54c This commits are what caused my issue. And also if you enable both bg and accent colors in this settings then as a result you'll get white and grey colors and not those that was chosed in this settings.

neobuddy89 commented 1 year ago

describe more on "bad" results?

the old implementation didn't work as intended and color swatches in "Wallpaper & Style" didn't apply correctly.

KoremuMekuro commented 1 year ago

describe more on "bad" results?

the old implementation didn't work as intended and color swatches in "Wallpaper & Style" didn't apply correctly.

By bad I mean washed, greish not vibrant or text is grey and not white if luminance is less than 90.App folders and app drawer are greish even if luminance is on 70 and not in the deep, darker variant of selected color as it was before, whereas qs and bg's are in their right deep, darker variant of selected color. But old implemantation worked fine on march 31st build of 9.3 for poco f3.And why then proprietary repainter works just fine(well, my only problem with it is that it's proprietary). It's bad looking for me only in dark mode, in light mode all looks fine and maybe even right, but I just love dark mode, because I feel pain in my eyes with light mode.

gwolf2u commented 1 year ago

For now this is the way we can have custom colors Old implementation had more issues than fixes, so for now we keep what we have with the focus to improve when and where possible

KoremuMekuro commented 1 year ago

For now this is the way we can have custom colors Old implementation had more issues than fixes, so for now we keep what we have with the focus to improve when and where possible

So my only hope is on iconify for open source solution.Sad.

KoremuMekuro commented 1 year ago

For now this is the way we can have custom colors Old implementation had more issues than fixes, so for now we keep what we have with the focus to improve when and where possible

I can say that that 'new' implementation have more issues than fixes.For example luminance is affecting text, luminance at default 100 turnes any color to white and if both bg color and accent color enabled, then you'll get white as accent and grey as bg no matter what colors are selecten and niether chorma nor luminance nor tint bg will have any affect.So you can only change bg or accent color, and cuz of that you're relaying on default monet engine and your wallpaper, cuz you need one color from that, cuz again, this 'new' implementation isn't working with enabled custom accent and bg colors.So what the point then in this 'new' implementation anyway?