search

create3000 / x_ite

X_ITE X3D Browser, view and manipulate X3D and VRML scenes in HTML.
https://create3000.github.io/x_ite/
Other
67 stars 15 forks source link

NavigationInfo @type is a JSON String not a JSON array. Data from browser.toJSONString() #146

Open coderextreme opened 1 year ago

coderextreme commented 1 year ago

image

Talk to Don and Vince if you disagree. I will back you, but it may require a few changes...

coderextreme commented 1 year ago

It's also possible to accept either in JSON Schema. I will work on that too. I'll broach the discussion.

create3000 commented 1 year ago

The issue is not whether NavigationInfo.type should be coded differently, but whether MFString values should be coded differently, and that will probably not be the case.

coderextreme commented 1 year ago

I agree, but no one wants to discuss it frankly or honestly, they just avoid, avoid, avoid. So I'm looking to supporting both in JSON schema, just for NavigationInfo @type. I agree that all MFStrings should be coded the same.

coderextreme commented 1 year ago

JSON schema has been tested, but I haven't changed the schema generation script yet.

coderextreme commented 1 year ago

If you change MFString implementation, let me know. I am currently assuming that MFStrings are arrays. I have 2 branches of code, one, .json, with NavigationInfo.type as a string. The other, .x3dj as an array. I can merely substitute array for string in the schema if and when the time is right.

coderextreme commented 1 year ago

Current X3dtoJson.xslt documentation has NavigatorInfo@type as an array.

coderextreme commented 6 months ago

I've got changes to X3dToJson.xslt if you are interested. I will be pushing this through my pipelines.