search

creationid / creators

Central place to register creation id creator ids. These are used to digitally identify anything.
https://creationid.org
BSD 2-Clause "Simplified" License
9 stars 31 forks source link

Add T-SIM7000G #21

Closed tyeth closed 1 year ago

tyeth commented 1 year ago

Adding the Lilygo TTGO T-SIM7000G. Rather than take the next number in the LilyGo list for creation_id I've gone with the product variant code from the aliexpress official page of 9102. (I assume we should to follow the existing id prefix when picking the creation ID? If not then I would have stuck with my original commit of 0x00009102). Also what do the underscores mean in creation/creator IDs?

This commit relates to https://github.com/tyeth/circuitpython/tree/add-lilygo-ttgo-tsim7000g

jepler commented 1 year ago

Please ping when you mark this PR as ready for review

tyeth commented 1 year ago

Glad I didn't pull the trigger on this one, the T-PCIE also uses that number, so I might as well go for the next in the list for each of them. Sadly I'm having bring-up issues so stalled on this one.

tyeth commented 1 year ago

pinging @jepler - ready for merge. Was held up by some ESP-IDF issue now resolved. I'm also going to stick in a pull request for the T-Display-S3 and the T-QT Pro, which both have earlier models so should I predefine those too? (i.e. T-QT as well as T-QT Pro) Or should I only add the IDs for the specific boards I plan to upstream this month? I plan to do the T-Sim7000G, the T-PCIE (with Sim7600/7070 pcie module), the T-QT-Pro and the T-Display-S3.

jepler commented 1 year ago

I haven't received any guidance on how to handle "speculative" allocations, where someone hopes plans to add support for a piece of hardware but the timeline or outcome is uncertain. My gut feeling is that since the address space is so large, there's little harm in such allocations. The main problem I could anticipate would be that multiple people might request an allocation for the same piece of hardware.