creationix / couch-client

A minimal CouchDB client that easy and powerful
MIT License
101 stars 9 forks source link

view method & licence #4

Closed flashingpumpkin closed 13 years ago

flashingpumpkin commented 13 years ago
creationix commented 13 years ago

Why did you pull in underscore as a dependency? Node controls it's V8 version and so you can saftly use all the ES5 Array.prototype stuff built in. For example, your code:

u.each(u.keys(obj), function(key) { ... })

can be written as:

Object.keys(obj).forEach(function (key) { ... });

It's all built in. Also please follow the same code style by running code through JSLint (I see some missing semicolons)

creationix commented 13 years ago

I cherry picked the license file in, thanks.

flashingpumpkin commented 13 years ago

Why did you pull in underscore as a dependency? Node controls it's V8 version and so you can saftly use all the ES5 Array.prototype stuff built in

wasn't me :) change

flashingpumpkin commented 13 years ago

Updated

creationix commented 13 years ago

Thanks, merged and published to npm.