search

creationix / couch-client

A minimal CouchDB client that easy and powerful
MIT License
101 stars 9 forks source link

Test & error handling #5

Open flashingpumpkin opened 13 years ago

flashingpumpkin commented 13 years ago

The view function didn't handle errors properly. Now it actually looks at the content returned before calling the callback. Also, I adopted a queue for views. :-o

michael commented 13 years ago

Had the same problem.

Flashingpumpkin: Not sure if Tim would rather prefer delivering the original error object { error: 'not_found', reason: 'missing_named_view' }

instead of a modified one, in order to keep the code-base super-small.

Thx for the patch anyway :)

-- Michael

candland commented 13 years ago

@devioustree Should this pull request be closed? Looks like it on a quick glance.

michael commented 13 years ago

Fixed this in my fork, among other things. See https://github.com/michael/couch-client/commit/011698b10a5d21ab43d86aa277884f92b48e24ed