search

creationix / js-git

A JavaScript implementation of Git.
MIT License
3.83k stars 264 forks source link

Port git-browser to android using phonegap. #53

Open creationix opened 11 years ago

creationix commented 11 years ago

http://plugins.cordova.io/#/org.chromium.socket

To add a new platform to git-browser, you only need create a new target in the make file and create a new bootstrap file in the src folder. Then add whatever libraries you need to implement this.

The hardest part for me is actually testing the code. I don't know how to use phonegap/cordova pluguns. I do have a several Android devices for testing and have extensive experience with adb.

kzahel commented 10 years ago

I did some work with this and I found the cordova socket plugin to be pretty unusable at this point.

creationix commented 10 years ago

Did you try with the new chrome app support in cordova? I was unable to get it to run at all, but I really like the push to chrome adt workflow if it actually worked.

kzahel commented 10 years ago

Yeah I was porting my torrent app to the chrome.socket cordova stuff. I got it working, after debugging some very fundamental bugs in the chromesocket.java implementation. But the socket code is very old school java (thread-per-connection) and .connect() calls block the entire js interpreter thread... so the current chromesocket.java implementation is really a prototype. I was considering rewriting it to be evented, but I have such a hard time with java :-\ i think it would likely work fine for git-browser, i doubt it calls connect very often?

On Fri, Feb 7, 2014 at 9:39 AM, Tim Caswell notifications@github.comwrote:

Did you try with the new chrome app support in cordova? I was unable to get it to run at all, but I really like the push to chrome adt workflow if it actually worked.

Reply to this email directly or view it on GitHubhttps://github.com/creationix/js-git/issues/53#issuecomment-34479485 .

creationix commented 10 years ago

Yeah, when using git:// protocol there is just one connect per clone/pull command. I hope they improve their code soon.