search

creationix / msgpack-js

The msgpack protocol implemented in pure javascript.
http://msgpack.org/
MIT License
253 stars 48 forks source link

Medium/large buffer are mishandled #19

Open susano opened 7 years ago

susano commented 7 years ago

There is a bit of confusion in the code around types 0xd8 and 0xd9. I resolved it in favor of Buffers in 383af43cb3b513b5e543859ac61d910c1a41bdb4.

creationix commented 7 years ago

Thanks. Does this commit need to be merged into master somehow? I don't see it there.

susano commented 7 years ago

Not sure whether that commit should be merged in master, it works for my usage but likely will render the code incompatible with earlier versions. I do not know what the Right solution would be for this. I included the commit above more as an indication of where the troublesome code is.