Closed chakrit closed 9 years ago
Official spec: https://github.com/msgpack/msgpack/blob/master/spec.md
Could this help https://github.com/creationix/msgpack-js/issues/15?
@doughsay I would expect that to fix it. I wonder if @chakrit still wants to merge.
@DerGuteWolf see creationix/msgpack-js-browser#6
:+1:
Wow, I've almost forgotten this PR, it has been so long. Also buried under a pile of other GH notifications.
I'll try to get this mergeable tonight, hopefully.
@chakrit cool :smile:
@creationix @nkzawa I've merged master back into my fork and gotten rid of the only README conflict.
npm test
passes but I have lost access to the project that was in need of this so let me know if anything else should be done.
Reference: https://gist.github.com/frsyuki/5432559#types-extension-type GH Issue: https://github.com/creationix/msgpack-js/issues/7
undefined
are handled, uses thefixext 1
extension type instead.raw
-related things.str
type family decoded to node string.bin
type family decoded to node Buffer.ext
andfixext
type family decoded to a [type, Buffer] tuple.fixext 1
which is just 1-byte long so a simple [type, value] is returned instead.ext
andfixext
since there is no way/need in JS to specify and encode "extension" type. Would be good to have tests on decoding part though since other languages/implementation may have made use of them.