search

creationix / nstore

nStore is a simple, in-process key/value database for node.js
MIT License
392 stars 31 forks source link

0.2.1 branch for node 0.4.3 #20

Closed dotmaster closed 13 years ago

dotmaster commented 13 years ago

Hi Tim,

your nStore implementation fails for me on node 0.4.3. I tracked down the issue to when you set the input buffer length to 0. It seems to me, that newer versions of node a) don't allow this b) there is a bug in node

anyways it never returns from there. I fixed the issue by using a separate variable input_length to track the position in the buffer.

Also I see, that you did some major refactoring and 0.3.0 is still unstable, so I decided to fix 0.2.1 in the meanwhile. Hope this is appreciated.

Best regards

Gregor

creationix commented 13 years ago

It's a bug in node, but I don't mind working around it. I'll review your patch and hopefully pull it in.

creationix commented 13 years ago

It's working now in v0.4.9? do you still need this merged?

dotmaster commented 13 years ago

Hi Tim,

No, don't worry. I fixed the issue for me.

Thanks

Gregor

Inviato da iPhone

Il giorno 08/lug/2011, alle ore 23:39, creationixreply@reply.github.com ha scritto:

It's working now in v0.4.9? do you still need this merged?

Reply to this email directly or view it on GitHub: https://github.com/creationix/nstore/pull/20#issuecomment-1535883