search

creationix / topcube

Webkit Bindings for node
MIT License
403 stars 37 forks source link

Node v0.10.x #21

Closed springmeyer closed 11 years ago

springmeyer commented 11 years ago

Adds support for building with node-gyp to allow using topcube with node v0.10.x

springmeyer commented 11 years ago

Just found that this is broken in node v0.8.x:

$ npm isntall

> topcube@0.1.3 preinstall /home/ubuntu/topcube
> node package.js

^Cubuntu@ip-10-196-47-74:~/topcube$ npm install

> topcube@0.1.3 preinstall /home/ubuntu/topcube
> node package.js

npm ERR! Error: It doesn't look like npm is installed.
npm ERR!     at /usr/lib/nodejs/npm/lib/explore.js:23:43
npm ERR!     at Object.oncomplete (fs.js:297:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <npm-@googlegroups.com>

npm ERR! System Linux 3.2.0-25-virtual
npm ERR! command "nodejs" "/usr/bin/npm" "explore" "npm" "-g" "--" "pwd"
npm ERR! cwd /home/ubuntu/topcube
npm ERR! node -v v0.8.20
npm ERR! npm -v 1.2.11
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/ubuntu/topcube/npm-debug.log
npm ERR! not ok code 0
/bin/sh: 1: /bin/node-gyp-bin/node-gyp: not found

npm ERR! topcube@0.1.3 preinstall: `node package.js`
npm ERR! `sh "-c" "node package.js"` failed with 1
npm ERR! 
npm ERR! Failed at the topcube@0.1.3 preinstall script.
npm ERR! This is most likely a problem with the topcube package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node package.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls topcube
npm ERR! There is likely additional logging output above.

npm ERR! System Linux 3.2.0-25-virtual
npm ERR! command "nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /home/ubuntu/topcube
npm ERR! node -v v0.8.20
npm ERR! npm -v 1.2.11
npm ERR! code ELIFECYCLE
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/ubuntu/topcube/npm-debug.log
npm ERR! not ok code 0
springmeyer commented 11 years ago

it may be the npm explore npm syntax is not compatible with older node versions. Seems like I may need to move the logic inside package.js into the binding.gyp

sk1p commented 11 years ago

npm explore npm also fails on debian (unstable) if you use node and npm from the debian packages. Also, the node-gyp binary (from the package) is installed as /usr/bin/node-gyp

springmeyer commented 11 years ago

okay, this is now ready to go: tested on osx (node v0.10.13), windows 7 (node v0.10.12), and ubuntu precise (node v0.8.19)

springmeyer commented 11 years ago

thanks!

kapouer commented 10 years ago

About npm explore npm: if only someone opened a bug on debian BTS i would have fixed it ;)

springmeyer commented 10 years ago

@kapouer I don't think the bug with npm explore has anything to do with debian, rather it is just not valid with older node version, which is fine.