search

creationix / wheat

Wheat is a blog engine for coders written in node.JS
Other
1.36k stars 134 forks source link

attempt to remove execPipe function #44

Open CrypticSwarm opened 12 years ago

CrypticSwarm commented 12 years ago

The exec Pipe function looks to do about the same as what child_process.exec does. I thought that it should be removed and use child_process.exec instead.

Currently this is not ready to merge. At the moment the graphs images don't render correctly. They are about 5% smaller. Any ideas why this isn't working?

austinyun commented 12 years ago

Is it possible that the exec version is actually the correct behavior and execPipe is for some reason rendering them unnecessarily large?

CrypticSwarm commented 12 years ago

No, highly doubt it. This code doesn't work. I was mainly posting up for any suggestions why it wasn't working the way I thought it should. (The images don't render in the browser.)

CrypticSwarm commented 12 years ago

This is now working correctly. It was a problem with the encoding of the streams. Should be ready to pull.