creative-builds / WSA-Magisk

A custom Windows Subsystem for Android with GApps, Magisk and KernelSU
https://github.com/LSPosed/MagiskOnWSALocal
GNU Affero General Public License v3.0
246 stars 129 forks source link

Miscellaneous changes #13

Closed sn-o-w closed 1 year ago

sn-o-w commented 1 year ago
sn-o-w commented 1 year ago

@rabilrbl Magisk-integrated builds aren’t finished because you changed the line related to Gen_Rand_Str.

Even if you keep using /dev/urandom, there are errors such as write error: Broken pipe as you can see: https://github.com/creative-builds/WSA-Magisk/actions/runs/3589180178/jobs/6041351490#step:5:143

It looks like GitHub Actions doesn’t like /dev/urandom... But I've found a solution: haveged. No more write error: Broken pipe. 😎

I also had to add back echo "artifact=$(echo "$artifact_name")" >> $GITHUB_OUTPUT to build.sh, otherwise, the Custom Build workflow will not be able to upload the artifact. I realized this ~11 hours ago. That’s why I closed the previous PR to be able to fix the problem.


Anyways, you can check out builds are fine now with this PR:

sn-o-w commented 1 year ago

@rabilrbl So... is this okay? 🤔 Do I need to make other changes? Everything looks fine. 😊