Closed sn-o-w closed 1 year ago
@rabilrbl Magisk-integrated builds aren’t finished because you changed the line related to Gen_Rand_Str
.
Even if you keep using /dev/urandom
, there are errors such as write error: Broken pipe
as you can see: https://github.com/creative-builds/WSA-Magisk/actions/runs/3589180178/jobs/6041351490#step:5:143
It looks like GitHub Actions doesn’t like /dev/urandom
... But I've found a solution: haveged. No more write error: Broken pipe
. 😎
I also had to add back echo "artifact=$(echo "$artifact_name")" >> $GITHUB_OUTPUT
to build.sh, otherwise, the Custom Build workflow will not be able to upload the artifact. I realized this ~11 hours ago. That’s why I closed the previous PR to be able to fix the problem.
Anyways, you can check out builds are fine now with this PR:
@rabilrbl So... is this okay? 🤔 Do I need to make other changes? Everything looks fine. 😊
sudo apt-get update
too${{ steps.wsa.outputs.artifact }}
for build.yml tooset-output
deprecation warnings