Use latest Winetricks + manually download msxml6 to avoid occasional …

creative-builds / WSA-Magisk

A custom Windows Subsystem for Android with GApps, Magisk and KernelSU

https://github.com/LSPosed/MagiskOnWSALocal

GNU Affero General Public License v3.0

246 stars 129 forks source link

Closed sn-o-w closed 1 year ago

sn-o-w commented 1 year ago

…download falling

By default, Winetricks package provided within Ubuntu is pretty old. We can use the latest version from their official GitHub repo.
Sometimes, msxml6 fails to download, I mean it fails to download the msxml6's URL mentioned in Winetricks. But we have the msxml6 available in this repo. So, therefore, download msxml6 we have in order to avoid occasional download falling.

rabilrbl commented 1 year ago

Thanks for the PR @sn-o-w

rabilrbl commented 1 year ago

sn-o-w commented 1 year ago

@rabilrbl warning: Cannot find cabextract. Please install it (e.g. 'sudo apt-get install cabextract' or 'sudo yum install cabextract').

Looks like the latest winetricks needs cabextract to be installed.

No more error if cabextract is manually specified for sudo apt-get install -y command as you can see here: https://github.com/sn-o-w/WSA-Magisk-1/actions/runs/3776487134/jobs/6419779365

I can submit a new PR with more changes, if necessary.