search

creativeaura / threesixty-slider

jQuery 360 image slider plugin
http://creativeaura.github.io/threesixty-slider
854 stars 234 forks source link

v2.0 responsive auto height does not fit original image proportion. #56

Open kacperpl1 opened 9 years ago

kacperpl1 commented 9 years ago

I've got my slider loaded on click which switches the div content from image to slider. Auto height calculation is off by 4px so I've had to add -4px margin to the initial image style.

Additionally either responsive mode should calculate the height initially during the load instead of defined height parameter or it should calculate proportions with this parameter.

kacperpl1 commented 9 years ago

It looks like its not constant 4px but its off by 1% of image height

simonseddon commented 9 years ago

Working responsively I've found setting responsive:false and adjusting the sizing of images to width:100%; height:auto; solves a few issues - although this can leave a gap underneath the images. Ideally there would be no px values defined at all.

creativeaura commented 9 years ago

Let me run few more test to fix the issue. Will be fixed very soon