creativecommons / cc-legal-tools-app

Legal tool (licenses, public domain dedication, etc.) management application for Creative Commons
https://creativecommons.org/licenses/
MIT License
94 stars 92 forks source link

[Bug] HTML print layout looks bad #281

Open TimidRobot opened 2 years ago

TimidRobot commented 2 years ago

Description

HTML print layout looks bad

We expect people may print all of the legal tools Deeds and Legal Codes pages. The following list pages provide links to the legal tools:

Reproduction

  1. Ex. legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en

Expectation

Screenshots

Screen Shot 2022-04-22 at 08 24 39 Screen Shot 2022-04-22 at 08 24 47 Screen Shot 2022-04-22 at 08 25 08

Environment

AMMAR-62 commented 2 years ago

Anyone on this issue yet?? ... may I work on this??

TimidRobot commented 2 years ago

Anyone on this issue yet?? ... may I work on this??

@AMMAR-62 no one else is working on this yet. Please keep the print media CSS in its own file and keep it as simple as possible.

MdSahil-oss commented 2 years ago

@TimidRobot I'm new to creativecommons, I think this issue has been resolved because when I visit to the page https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en I don't see any kind of icons/text overlapping using browser chrome/firefox on my laptop (window 11 OS) but I see text/icon on the page doesn't render very well (looks very bad) on the screen size (width) 500px (or smaller)

Screenshots ![Screenshot (6)](https://user-images.githubusercontent.com/85174511/188305952-1e9ab370-33c7-41e6-827b-90b8bc84fd70.png) ![Screenshot (8)](https://user-images.githubusercontent.com/85174511/188305979-c753d4d1-d456-4d4a-a329-380a53870995.png)

Do we need to fix this ?

TimidRobot commented 2 years ago

@MdSahil-oss

[...] I think this issue has been resolved because when I visit to the page https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en I don't see any kind of icons/text overlapping using browser chrome/firefox on my laptop (window 11 OS) [...]

The issue is only visible from print dialog/output.

[...] I see text/icon on the page doesn't render very well (looks very bad) on the screen size (width) 500px (or smaller) [...] Do we need to fix this ?

Sure! Help documenting the responsiveness issue(s) in an issue would also be welcomed.

Akbar-Ibrahim commented 2 years ago

I'd like to work on this, if it's okay

kevinRapahel commented 2 years ago

@TimidRobot I would love to work on this too, can I help?

adetyaz commented 2 years ago

hello @TimidRobot , Please how'd love to work on this , How can I help?

tolubishops0 commented 2 years ago

Hello, my name is Tolu an Outreachy applicant. I’m new to Creative Commons community. The page looks good and responsive on loading it on my phone, but I couldn’t help but notice that the hamburger button me meant for the side-bar is not responsive and the screen goes blank and all the texts disappear as one clicks on said button. I’d like to give this a shot by fixing it, and would be creating a pull request. Thank you.

Screenshot ![F2858E19-2B3A-4292-B1CB-53282BE0F0F9](https://user-images.githubusercontent.com/88975947/195715564-c448a241-ef82-4a74-8c69-403e75638226.png)
TimidRobot commented 2 years ago

Hello, my name is Tolu an Outreachy applicant. I’m new to Creative Commons community. The page looks good and responsive on loading it on my phone, but I couldn’t help but notice that the hamburger button me meant for the side-bar is not responsive and the screen goes blank and all the texts disappear as one clicks on said button. I’d like to give this a shot by fixing it, and would be creating a pull request. Thank you.

@tolubishops0 The menu is blank unless there is a properly configured WordPress instance for the page to pull data from or the Django app is providing dummy data to populate the menu.

If you have ideas about how the menu might be improved under either use case, please open new issue(s)

Tapo41 commented 1 year ago

I want to contribute to this if it is still open .

TimidRobot commented 1 year ago

@Tapo41 yep, please see Contribution Guidelines — Creative Commons Open Source

shreyansh1910 commented 1 year ago

@TimidRobot As i see this problem still persist . i would like to work on it. I need few information does this issue only persist in this page or some other page also. Do you want me to create new css for printing or make correction to already present css . (please guide me I am little new)

TimidRobot commented 1 year ago

@TimidRobot As i see this problem still persist . i would like to work on it. I need few information does this issue only persist in this page or some other page also. Do you want me to create new css for printing or make correction to already present css . (please guide me I am little new)

Please see Contribution Guidelines — Creative Commons Open Source.

I think a new CSS file.

vanamaabhi2004 commented 1 year ago

please assign me to work on it

BalrajDhakad commented 8 months ago

Hey, This is Balraj, I want to work on this issue could you please assign it to me. @TimidRobot

TimidRobot commented 8 months ago

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

BalrajDhakad commented 8 months ago

I have read it but able to get what you want to say about assigning this issue to me @TimidRobot

SamarthShukla17 commented 8 months ago

Hi @TimidRobot Is this https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en the page you want to be addressed in the issue?

TimidRobot commented 8 months ago

@SamarthShukla17 That page is an example of a Deed. We want to improve printing of all of the tools Deed and Legal Code pages (I also updated the issue description).

SamarthShukla17 commented 8 months ago

Thankyou @TimidRobot for the clarification.

TimidRobot commented 1 week ago

@nobodys-ghost please make a comment on this issue so GitHub will allow me to assign it to you

nobodys-ghost commented 3 days ago

I've added a pull request to fix this issue. (see #484 )