search

creativecommons / cc-resource-archive

Collection of resources on Creative Commons (CC) tools and other open topics
https://resources.creativecommons.org/
MIT License
57 stars 127 forks source link

[Bug] The thumbnail images should have proper alt-text in listing.html #307

Open Murdock9803 opened 2 months ago

Murdock9803 commented 2 months ago

Description

In the listing.html file, there are two <img> tags present with class thumbnail. The image tags do not have an alt attribute specified. This needs to be corrected for all the resources with suitable text in alt attribute.

Reproduction

  1. Go to the codebase at https://github.com/creativecommons/cc-resource-archive.
  2. Open the listing.html file in docs/_layouts/listing.html.
  3. Scroll until the <img> tags inside #thumbnaillist.
  4. See error.

Expectation

The resources should have corresponding suitable alt attributes inside the <img> tag.

Resolution

lokendra005 commented 2 months ago

@possumbilities can you assign this issue to me

Murdock9803 commented 1 month ago

@lokendra005 You can move forward with raising a Pull Request and then it will be assigned to you if the issue gets resolved 🙌

Murdock9803 commented 2 days ago

Since multiple people tried to solve the issue, and lacked some minute things with the PRs, here is some more context about the process we are aiming to follow, as per @possumbilities : https://github.com/creativecommons/cc-resource-archive/pull/328#issuecomment-2391531317