search

creativecommons / cc-resource-archive

Collection of resources on Creative Commons (CC) tools and other open topics
https://resources.creativecommons.org/
MIT License
59 stars 134 forks source link

[Bug] Resource Listing - Image not clickable + resource View in detail button opens in same page #321

Closed mahak-juriani closed 2 months ago

mahak-juriani commented 2 months ago

Description

Resource Listing Page - Image should be clickable just like the title below it Inside Resource Page - View in detail / Visit button should open in new page as most of the links are external websites

Reproduction

  1. Go to resources page (default home page)
  2. Hover over any image - Image should be clickable just like title below the image
  3. Also, click on the title
  4. Visit / View in detail button opens link in same tab, should open in new tab

Expectation

Resource listing page should have thumbnail images clickable View / View in detail button when clicked in a particular resource page should open new tab instead of going to same tab

Screenshots

https://github.com/user-attachments/assets/513694d7-cc67-45f1-b808-b63114718963

Resolution

Murdock9803 commented 2 months ago

@mahak-juriani The project follows vocabulary, CC's internal design system to determine the styles for various elements. You can observe on other Creative Commons pages, the images are not clickable in similar areas. More context: https://creativecommons.org/blog/

mahak-juriani commented 2 months ago

@Murdock9803 Thank you for the input, the reference helped me understand the context better. Regarding clicking on View in Detail / Visit buttons, should we open such files / pages in new tab since most of these are pdf / external websites? Thanks

Ajay-singh1 commented 2 months ago

@mahak-juriani No I don't think the links lead to an external website.

Clemo97 commented 2 months ago

So then this issue should be marked as closed/done

possumbilities commented 2 months ago

Closing.