Closed shailee-m closed 2 years ago
@brylie I have also added a fix for the unit test cases and integration test cases that were failing. For the unit test cases it required a babel plugin to use some webpack functionality.
All integration test cases were failing as the queries were done outside the iframe. I have created a wrapper for selecting iframe. Should I add in the docs too?
For this, you will have to change the test pipeline commands. Use npm run build-component && npm run test-component
Yes, please update the docs. With the web component approach, theiframe
should no longer be necessary, so let's remove the iframe
if possible.
Could you also include a demo/example code showing how to use the Chooser web component in a standard HTML page?
@brylie Used this in custom html to integrate it
<script src="https://unpkg.com/vue"></script>
<script src="http://127.0.0.1:8081/license-chooser.js"></script>
<license-chooser></license-chooser>
Used this in custom html to integrate it
Go ahead and add the example code to the project README, assuming we will use unpkg as CDN instead of localhost.
Used this in custom html to integrate it
Go ahead and add the example code to the project README, assuming we will use unpkg as CDN instead of localhost.
done
Due to node-gyp
errors. I am not even able to install the node modules for this project.
Could you please include the contents of the dist/
folder in this pull request so I can test the files locally?
Once we publish the new @creativecommons/vocabulary-components
package, we can use it in this project instead of @creativecommons/vue-vocabulary
. Likewise, we will be able to add dist/
back to .gitignore
, since we should be able to build the project now (using node 14 at the least). After replacing node-sass
with sass
, the project should build successfully with node 16.
Hei @shailee-m. The Vocabulary Components package now has a 0.1.0 release:
https://www.npmjs.com/package/@creativecommons/vocabulary-components
Let's use
vocabulary-components
as a dependency here, instead ofvue-vocabulary
.
@brylie removed dist folder and added vocabulary-components as dependency
@brylie added assets, and fonts dependency. Also, created this PR to move assets to cc-assets folder
Also, created this PR to move assets to cc-assets folder
Let's keep the "degrees of openness" image in this project for now or link directly to a version hosted on the Wikimedia Commons.
FontAwesome icons, like the info circle should be imported directly from FontAwesome.
At least one of the FontAwesome icons is displayed really large, seen below. If this isn't trivial to fix in the current pull request, we can open a follow-up bug fix.
Steps to reproduce:
- in license step 1, choose "Yes. I know the license I need."
- in step 2, choose a license
- view the "Recommended License" section, below the license icons
done
Fixes
Fixes #366 by @brylie Fixes #374
Description
Wraps in vue component wrapper and builds into a web component. Added new build command for the same
Checklist
Update index.md
).main
ormaster
).