creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
98 stars 123 forks source link

Default build output without header and footer #384

Closed brylie closed 2 years ago

brylie commented 2 years ago

The current default build output contains a header and footer. Rather the default should only include the Chooser component, without surrounding page elements, since the Chooser is intended to be embedded into other pages/projects.

Task

brylie commented 2 years ago

This issue has been partially fixed by modifying the build-component command in package.json to default to embedded mode:

https://github.com/creativecommons/chooser/blob/412c9a053451846c10414828ad7b9835facea2e4/package.json#L18

However, ideally, we wouldn't need the embedded flag.

brylie commented 2 years ago

@shailee-m, can we close this issue?

shailee-m commented 2 years ago

@brylie Yes

shailee-m commented 2 years ago

@brylie I do not have the access to close this issue