Closed possumbilities closed 1 year ago
All of the unit tests
pass:
But at current the cypress end-to-end tests
all fail. Looking through the logs that's been going on for a while and started at #371 I'm unsure of the specific cause.
It does look like the https://github.com/creativecommons/chooser/pull/371#issuecomment-1001713854 denotes that the change to correct the iframe error on the cypress tests requires the commands in the test pipeline be updated accordingly, but I don't know that they were.
9 PRs have been merged since theses tests began failing (and without them passing successfully).
It all warrants further investigation to sort the actual cause, since they all fail at the moment.
@possumbilities I have found the fix for cypress end to end
tests. So I will be opening a new issue to resolve that bug. Plus we would also require to discuss the upgradation of cypress from 6.x version to 12.x version the latest version.
Fixes
Fixes:
418
439
440
441
442
Description
418
439
Before
After
440
Before
After
441
Before
After
The previous questions can be viewed by checking out Release 0.2.0:
442
Before
After
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added or updated tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginFor the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```