creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
98 stars 121 forks source link

Adjusted positioning of the 'Confused Need Help' and 'Recommended License' sections in mobile view #459

Closed soustab10 closed 1 year ago

soustab10 commented 1 year ago

Fixes

Fixes #455 by @soustab10

Description

Fixes the position of 'Confused Need Help' and 'Recommended License' sections in mobile view for better ease of the user.

Screenshots

image image

Device used for reference: Samsung Galaxy S20 Ultra

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
possumbilities commented 1 year ago

Hi @soustab10 can you update your branch here with the latest version of main to see if the tests pass now? I merged in another PR that should fix the failing tests here, but it'll need the newest commits first.

soustab10 commented 1 year ago

Hi @soustab10 can you update your branch here with the latest version of main to see if the tests pass now? I merged in another PR that should fix the failing tests here, but it'll need the newest commits first.

Sure. Thank you.

soustab10 commented 1 year ago

@possumbilities Thank you, build test has passed.