search

creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
98 stars 121 forks source link

Upgrade Cypress to latest #460

Closed Cronus1007 closed 1 year ago

Cronus1007 commented 1 year ago

Description

Right now the version of Cypress used for the E2E testing is v6 while the latest version of cypress is v12. I believe that the Cypress testing should be upgraded since several new features have been implemented especially for Vue.js especially in the version 10.

Important Links

Migration Guide for Cypress

Resolution

@possumbilities Would like to know your opinion about it?

possumbilities commented 1 year ago

@Cronus1007 My first major concern would be if newer Cypress is going to be compatible with the older version of Vue that's running in the chooser and its related dependencies and whether it makes more sense to do this upgrade after the Vue3 upgrade?

Thoughts?

Cronus1007 commented 1 year ago

@possumbilities In Chooser we are using cypress as a frontend tool so it hadn't much to do with the framework used or the version of the framework used. The main reason I am proposing it is the reason of a new feature called initSpecRoutine since the version which we are using right now doesn't have a great support for before, beforeAll, after and afterAll functionsfunctions as compared to that of the older version. Additionally we can test the application on Firefox browser as well so such reasons are prime reason why I would like to have an upgrade.

possumbilities commented 1 year ago

@Cronus1007 I'm fine with this if there's data to support (even just testing it) that it won't break. My concern was node version conflicts between technologies.

Cronus1007 commented 1 year ago

@possumbilities I dont have any data to support it. One thing which we can do is by just testing it out whether cypressv12 is going to be compatible with nodev14. And then you can test it on your local enviornment. In my opinion it will be we just need to tweak code a little bit i.e. introduce the hooks like before, beforeAll, after and afterAll statements.

Cronus1007 commented 1 year ago

@possumbilities Nothing is breaking as of now in PR #470 . I just made the required shifts of the files.Could you please have a local run of the new scripts of the branch issue-460. Upgrading Cypress tov12 was supported by nodev14.