search

creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
98 stars 121 forks source link

Long word in 'Attribution Details' step breaks the UI #463

Closed soustab10 closed 1 year ago

soustab10 commented 1 year ago

Description

If an user a long single word title (title without blankspaces) in 'Title of Work' or 'Creator of Work' under Attribution Details section, it results in increase of width of the Mark Your Section thereby breaking the UI.

Reproduction

  1. Step 1: Choose Yes in Step 1 and select any license.
  2. Step 2: In the Title of Work or Creator of Work section write a very long singular name (Name without blankspaces). Adding any character (e.g. _ (underscore)) between words also works.
  3. See error.

Expectation

The width of the Mark Your Section should not change rather the template should grow vertically.

Screenshots

Desktop

image

Mobile

image

Environment

Additional context

This might be rare that user enters such an abnormal title, but it's possible and should be taken care of.

Resolution

UlbertAO commented 1 year ago

Hi, can I work on this?

soustab10 commented 1 year ago

@UlbertAO thanks for your interest to contribute on this project but it is not yet approved. Please refer the Contribution Guidelines to understand the labels. Also as mentioned in the issue description I would like to work on it. So, you may look at the other issues.

possumbilities commented 1 year ago

@soustab10 Good find! Thank you.❤️

You've already had several helpful contributions. It might be better to let someone else work on a PR for this.

soustab10 commented 1 year ago

@soustab10 Good find! Thank you.❤️

You've already had several helpful contributions. It might be better to let someone else work on a PR for this.

Okay @possumbilities ! Assign it to someone who's interested. I can fix it if it is not resolved after

possumbilities commented 1 year ago

@UlbertAO Would you still like to work on this?

AyushKaithwas commented 1 year ago

Hey I would like to work on this

codewithmide commented 1 year ago

Hello Maintainers, I would love to take up this issue if it is not assigned to anyone yet.

possumbilities commented 1 year ago

Passing along to @AyushKaithwas for now to work on. But it's fine to collab together if anyone wants to do that :)

codewithmide commented 1 year ago

Hey I would like to work on this

Hi @AyushKaithwas are you willing to collaborate?

AyushKaithwas commented 1 year ago

Passing along to @AyushKaithwas for now to work on. But it's fine to collab together if anyone wants to do that :)

Hey, I have fixed the issue, please review. https://github.com/creativecommons/chooser/pull/472

AyushKaithwas commented 1 year ago

I have closed the pull request for now, because I found a better fix, I am implementing that

AyushKaithwas commented 1 year ago

Fixed it, https://github.com/creativecommons/chooser/pull/474

UlbertAO commented 1 year ago

prevent right column from overflowing and word break on long text in … #475

here is another fix for root cause of this issue