creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
97 stars 124 forks source link

[Bug] No Windows equivalent command for `build-component` in package.json #480

Open kartiksprajapati opened 1 year ago

kartiksprajapati commented 1 year ago

Description

I noticed that the package.json file in this repository contains a build-component command for Linux, but there doesn't seem to be a Windows equivalent command for it. This can be problematic for Windows users who need to build the component.

Reproduction

  1. Clone git repo and install all dependencies with npm install
  2. Run npm run build-component
  3. See error.

Expectation

I expect that the package.json file should contain a command that works on both Windows and Unix-based systems, or there should be clear instructions on how Windows users can build the component.

Screenshots

image

Environment

Resolution

Pursottam6003 commented 1 year ago

Well Noticed! the page I guess we can update the build command using the following command

{
  "name": "my-component",
  "version": "1.0.0",
  "description": "My awesome component",
  "scripts": {
    "build-component": "npm run clean && webpack --config webpack.config.js",
    "clean": "rm -rf dist",
    "start": "webpack serve --config webpack.config.js"
  },
  "devDependencies": {
    "webpack": "^5.64.4",
    "webpack-cli": "^4.9.1"
  }
}

To run we can do this

npm run build-component

Nice work

dhruvgupta0503 commented 6 months ago

hi is this issue still open I would like to work on this issue

ayushdasgupta commented 6 months ago

Is it still open?