creativecommons / chooser

The new and improved CC license selection tool.
https://chooser-beta.creativecommons.org
MIT License
106 stars 143 forks source link

[Feature] Error pages are not styled/themed #532

Open TimidRobot opened 7 months ago

TimidRobot commented 7 months ago

Problem

Error pages are not styled/themed

Current 404 page: Screenshot 2024-04-24 at 11-47-50 Page not found · GitHub Pages

Description

The error pages should not disrupt the user experience

Alternatives

Do nothing

Additional context

Implementation

akshansh-modi commented 5 months ago

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

TimidRobot commented 5 months ago

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

@akshansh-modi Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs.

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

ankur-kalita commented 3 months ago

hey @TimidRobot I want to contribute to this issue , could you assign me this issue

kritika-76 commented 3 months ago

hello ! actually i want some help from you to start the project and how to start . i am the beginner and i am trying to do projects . but by some queries , i won't make it. can you please help me as a mentor?

saikatsardar01 commented 1 month ago

@TimidRobot How about this page?

https://github.com/user-attachments/assets/c08c544e-ff71-4635-99eb-b8a0776f8524

saikatsardar01 commented 1 month ago

If you like it I can give a pull request

egbadon-victor commented 3 weeks ago

@TimidRobot @possumbilities I was doing research on the implementation of this.

Could this be implemented upstream in the vocabulary repository. The reason for this thinking is as follows;

While a PR can be submitted for this specifically for this issue, I think it would be a great opportunity to standardize the error page structure.

Here is how I would go about it;

  1. Implement the error page styles in the vocabulary repository, along with creating a specimen in the context folder, to visaulize the error page, collaborating with project maintainers for feedback.
  2. Update the vocabulary version of the chooser repo to reflect the error styles update
  3. Implement the error page in the chooser repo, following the approved design system arrived at in step 1.

Please let me me know what you think about this.