This PR changes the color property of captions ensuring that they inherit their color from the parent element where the image/figure is placed. However, there are some things to note, which may be included in the USER TRAINING modules. See the technical details below.
Technical details
In the screenshot below, the parents are placed in a group with the tomato background colour. However, no text colour has been set for this particular column so any text found in this column will inherit it's colour from the body element.
Body Element:
We can set colours to individual blocks of text and paragraphs but for captions to inherit a colour other than that of the global body element, then the column where the images are placed needs to have a text colour set.
In the screenshot below, I have set a text colour (white) for the column where these images are places.
and the frontend render, the captions inherit the proper colour (white) instead of the color property of the global body element.
So in conclusion, for the inheritance to work properly, the parent element (group or column) where the image is placed needs to have a text colour set for it, else the captions will inherit the colour property of the next parent element that has a colour property set.
Screenshots
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update
index.md`).
- [x] My pull request targets the *default* branch of the repository (`main` or `master`).
- [x] My commit messages follow [best practices][best_practices].
- [x] My code follows the established code style of the repository.
- [ ] I added or updated tests for the changes I made (if applicable).
- [ ] I added or updated documentation (if applicable).
- [x] I tried running the project locally and verified that there are no
visible errors.
[best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
## Developer Certificate of Origin
Developer Certificate of Origin
```
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
```
Fixes
Fixes https://github.com/creativecommons/project_creativecommons.org/issues/148 by @brylie
Description
This PR changes the color property of captions ensuring that they inherit their color from the parent element where the image/figure is placed. However, there are some things to note, which may be included in the USER TRAINING modules. See the technical details below.
Technical details
In the screenshot below, the parents are placed in a group with the tomato background colour. However, no text colour has been set for this particular column so any text found in this column will inherit it's colour from the body element.
Body Element:
We can set colours to individual blocks of text and paragraphs but for captions to inherit a colour other than that of the global body element, then the column where the images are placed needs to have a text colour set.
In the screenshot below, I have set a text colour (white) for the column where these images are places.
and the frontend render, the captions inherit the proper colour (white) instead of the color property of the global body element.
So in conclusion, for the inheritance to work properly, the parent element (group or column) where the image is placed needs to have a text colour set for it, else the captions will inherit the colour property of the next parent element that has a colour property set.
Screenshots
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added or updated tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginDeveloper Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```