creativecommons / creativecommons.github.io-source

Source files for CC Open Source website
https://opensource.creativecommons.org/
MIT License
77 stars 161 forks source link

Make the secondary navigations reactive. #536

Open Dhruvi16 opened 3 years ago

Dhruvi16 commented 3 years ago

Problem

The guidelines pages have table of contents and that does not show what section is active right now.

Description

Make the table of content and table of progress reactive. This will highlight the active section as the user scrolls. Here is a similar demo.

Implementation

kenkirito commented 3 years ago

can i work on this issue

dhruvkb commented 3 years ago

@kenkirito since there is already @Dhruvi16's PR #537 that addresses this issue, if you could review that PR (by verifying that it works as expected), that would be very helpful.

kenkirito commented 3 years ago

sure

Arpitchugh commented 1 year ago

Is the issue still open? @dhruvkb you have a pending change expected in the PR

dhruvkb commented 1 year ago

The issue might be open, I'm not in touch with the code anymore. Maybe ask in the Slack channel?