Email textbox not optimized for mobile view

[soustab10]

Description

The email text box is not optimized for mobile view.

Reproduction

1. Go to Creative Commons Opensource in mobile view
2. Scroll to footer
3. See error.

Expectation

The width of the email text box should be adjusted for the device width.

Screenshots

Additional context

Resolution

• [x] I would be interested in resolving this bug.

[nitin-pandita]

I would like to work on it @TimidRobot

[adidevs]

Hey @nitin-pandita , since you are working on #712 ,shall I take up this issue?

[nitin-pandita]

Hey @nitin-pandita , since you are working on #712 ,shall I take up this issue?

sure , go for it

[adidevs]

@TimidRobot the fix to this issue is in the creativecommons/vocabulary-styles repository in the following file footer.scss

It needs to be updated and the following code added in the mobile() section:

@include mobile() {
    .subscription {
      .newsletter {
        width: 100%;
      }
   }
}

Should I submit a PR directly in that repository or create an issue there?

[TimidRobot]

@adidevs Hmmm... I'll let @possumbilities weigh in. I suspect we may want to mark this issue as blocked pending changes to Vocabulary.

[possumbilities]

@adidevs I would concur with @TimidRobot. There's a fix brewing that would address this differently, but is precisely this Issue in the new changes to Vocabulary. I'd say best to make this status: blocked for now.

[adidevs]

Thank you for your feedback @possumbilities and @TimidRobot !🙌

[nsundriyal62]

as i see there are no PR for this i am gonna genrate one

see u

[Lavanya-4321]

Hey @soustab10 can i work on the above issue?

[Ritesh92A]

I want to work on this issue please assign me this issue.

[Shailendrasingh189]

Can I work on this issue.

[abhishekjain58]

I want to work on this issue please assign me this issue.

[Ritesh92A]

Hey I clearly understood what issue is please assign this issue to me, I will sole it really quickly.

[TimidRobot]

@Ritesh92A @Shailendrasingh189 @abhishekjain58

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

[wisekiran]

Hi, I created a PR with a fix for this: https://github.com/creativecommons/creativecommons.github.io-source/pull/763

I've tested it locally, please review @TimidRobot