search

creativecommons / creativecommons.github.io-source

Source files for CC Open Source website
https://opensource.creativecommons.org/
MIT License
77 stars 161 forks source link

[Bug] The twitter link redirects to the main CC page #722

Closed Xaid-vfx closed 8 months ago

Xaid-vfx commented 1 year ago

Description

The current twitter link in the footer redirects to the main creative commons page.

Reproduction

  1. Go to https://opensource.creativecommons.org/
  2. Scroll to footer
  3. Click on Twitter icon
  4. See error.

Expectation

There's a specific CC open source twitter account. It would be more appropriate if the twitter link redirects to CC open source instead of CC main page. CC open source twitter - https://twitter.com/cc_opensource

Resolution

Ni-011 commented 1 year ago

Are you still working on this issue?

Xaid-vfx commented 1 year ago

Are you still working on this issue?

Yes @NitinRana01125532553

possumbilities commented 1 year ago

@Xaid-vfx Thank you for pointing this out.

The purpose of the global footer isn't to localize the items within it to the specific program/sub-org/product site it appears on, which could get confusing in breaking assumed conventions from site to site. The social icons there should behave the same across the sites that that footer is implemented on.

However, you raise a valid concern connected to this. I'd suggest an Issue needs to be created on the creativecommons/vocabulary repository outlining that the global footer and its social media icons don't account for product/sub-area/program-level social media linking in any reasonable way within the design.

I'd love to hear other suggestions, but this seems more an issue with Vocabulary's design, than with this site in particular?

possumbilities commented 1 year ago

@Xaid-vfx I'm happy to make that new Issue, but feel free to yourself and we'll close this one.

Saroj-pradhan commented 1 year ago

is this issue still going or closed ? i would happy to fix this issue , if didn't closed yet. please assign me the issue.

pushkar707 commented 8 months ago

Hi, I understand the issue. So I just need to change the link in the footer, right? Please assign me this issue. Thankyou

pushkar707 commented 8 months ago

I just made a PR#756 to solve this issue.

dhruvgupta0503 commented 8 months ago

hi, is this issue still open i want to work on this issue

TimidRobot commented 8 months ago

@Xaid-vfx Thank you for pointing this out.

The purpose of the global footer isn't to localize the items within it to the specific program/sub-org/product site it appears on, which could get confusing in breaking assumed conventions from site to site. The social icons there should behave the same across the sites that that footer is implemented on.

However, you raise a valid concern connected to this. I'd suggest an Issue needs to be created on the creativecommons/vocabulary repository outlining that the global footer and its social media icons don't account for product/sub-area/program-level social media linking in any reasonable way within the design.

I'd love to hear other suggestions, but this seems more an issue with Vocabulary's design, than with this site in particular?