Fix fallback for 'Visit site' link when repo.website is missing

Clemo97 commented 3 months ago

Fixes

The fallback URL for Visit site would redirect user back to home page when the website link doesn't exist.

Fixes #801 by @naishasinha

Description

The PR adds an or parameter in the Visit site redirect {{ repo.website or repo.url }} , that way if the website URL is non-existent it falls back to the github repo URL.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

naishasinha commented 3 months ago

Looks good! @TimidRobot

TimidRobot commented 3 months ago

@Clemo97 please mark the appropriate items in the Checklist of the pull request description

Clemo97 commented 3 months ago

@Clemo97 please mark the appropriate items in the Checklist of the pull request description

Noted and done @TimidRobot. I've also fixed the spacing issue repo.website or repo.url

Clemo97 commented 3 months ago

nice! thank you!!

Your welcome, @naishasinha and @TimidRobot are there any more tough and challenging issues within creative commons that need solving?

creativecommons / creativecommons.github.io-source