creativecommons / creativecommons.github.io-source

Source files for CC Open Source website
https://opensource.creativecommons.org/
MIT License
79 stars 173 forks source link

Align header with the Vocabulary design system #827

Closed Dev-JoyA closed 3 weeks ago

Dev-JoyA commented 1 month ago

Fixes

Description

This pull request implements the necessary adjustments to the header design to align with the current Vocabulary design system, including the addition of the 'Explore CC' dropdown and the 'Donate' button.

Technical details

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
Dev-JoyA commented 1 month ago

@Dev-JoyA please correct the description, it contains invalid markdown syntax in the Checklist

@TimidRobot Resolved

SisiVero commented 1 month ago

hi @Dev-JoyA , you can check and make updates or manually resolve the conflicts

Dev-JoyA commented 1 month ago

@TimidRobot Conflicts resolved @SisiVero Thanks for calling my attention to this

Dev-JoyA commented 1 month ago

@TimidRobot This is the page after fixing the error and testing Screenshot 2024-10-22 at 10 43 15

Dev-JoyA commented 1 month ago

Hello @TimidRobot I hope I get a thumps up from you this time around, the old header as been replaced with the new one Screenshot 2024-10-24 at 16 09 31