creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
155 stars 201 forks source link

Investigate italics in Section 2a5 of English legal code (version 4) #1028

Closed sarahpearson closed 4 years ago

sarahpearson commented 5 years ago

Describe the bug It appears that part of the 4.0 legal code (Section 2a5) in English is incorrectly appearing in italics. I'm not sure when or how this change occurred.

For example, see Section 2a5 of https://creativecommons.org/licenses/by-nc-sa/4.0/legalcode. It appears to be the case in all six licenses.

Screenshots I've attached a screenshot. Screen Shot 2019-09-24 at 8 47 51 AM

Expected behavior This portion of the legal code should not be italicized.

Desktop (please complete the following information):

Additional context Given CC's commitment not to alter the legal code of its tools, please don't change anything until getting sign-off from @peterspdx. For now, we just want to assess when/how this happened if it is possible to discern.

TimidRobot commented 4 years ago

I created two new branches within creativecommons/creativecommons.org to verify the proposed fixes:

  1. timid-baseline: https://timid-baseline.legal.creativecommons.org/licenses/by-nc-sa/4.0/legalcode
    • To verify broken behavior
  2. timid-css-test: https://timid-css-test.legal.creativecommons.org/licenses/by-nc-sa/4.0/legalcode
    • To verify fixed behavior

You may also want to check:

TimidRobot commented 4 years ago

@sarahpearson Please review 2. timid-css-test, above, to verify it looks the way you expect and that our fix hasn't introduced any new issues.

sarahpearson commented 4 years ago

This looks correct to me. Let's make sure @peterspdx signs off since this is a change/correction to the English legal code.

peterspdx commented 4 years ago

Signed off. Please deploy. Will be documented on legal code errata page.

TimidRobot commented 4 years ago

Change deployed