Closed TimidRobot closed 4 years ago
The one thing I noticed is that the capitalization is slightly different for a few languages: Bahasa, te Reo Maori, and portugues. Each of those was written as the translation team directed CC, so I'm inclined to think we should keep it as it is in the currently published lists.
@sarahpearson: Previously, the language names were specified twice: 1) language selector and 2) language footer.
With this update, they are only specified once and then used both places. I think it is better for them to be consistent. That means that no matter which we choose, there will be a change. Please comment on the iso_to_language
list in the update_cc4_includes.py
script with any changes you would like (starts at line 57 in the new file, on the right).
Ah, I understand now. The formatting as used in the footer (that we include manually when we create a new translation) is the one which reflects input from the team. So we should use that as the canonical. By my review, it looks like the only changes needed are to Bahasa Indonesia, te reo Maori, and portugues.
Ah, I understand now. The formatting as used in the footer (that we include manually when we create a new translation) is the one which reflects input from the team. So we should use that as the canonical. By my review, it looks like the only changes needed are to Bahasa Indonesia, te reo Maori, and portugues.
@sarahpearson: Updated in https://github.com/creativecommons/creativecommons.org/pull/1072/commits/66f938264b23bbab2ee7a39c98adb38c54f40614 (changes are live on testing)
deployed
Description
ja
,zh-Hans
, andzh-Hant
Other information
There's a lot of files changed by this pull request. Please review the python code and spot check the HTML files. When spot checking the HTML files, pay attention to the domain. Some of the links in the HTML files are absolute and will take you to production. You can begin spot checking the HTML rendering by starting from:
This PR contains changes to the legalcode files (and the python scripts that modify them), but the changes do NOT modify elements of the Legal Code Defined - Creative Commons.
Checklist
Update index.md
).master
branch of the repository.Developer Certificate of Origin