creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
155 stars 201 forks source link

Update Python tools to update language selector and language list #1072

Closed TimidRobot closed 4 years ago

TimidRobot commented 4 years ago

Description

Other information

There's a lot of files changed by this pull request. Please review the python code and spot check the HTML files. When spot checking the HTML files, pay attention to the domain. Some of the links in the HTML files are absolute and will take you to production. You can begin spot checking the HTML rendering by starting from:

This PR contains changes to the legalcode files (and the python scripts that modify them), but the changes do NOT modify elements of the Legal Code Defined - Creative Commons.

Checklist

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
TimidRobot commented 4 years ago

The one thing I noticed is that the capitalization is slightly different for a few languages: Bahasa, te Reo Maori, and portugues. Each of those was written as the translation team directed CC, so I'm inclined to think we should keep it as it is in the currently published lists.

@sarahpearson: Previously, the language names were specified twice: 1) language selector and 2) language footer.

With this update, they are only specified once and then used both places. I think it is better for them to be consistent. That means that no matter which we choose, there will be a change. Please comment on the iso_to_language list in the update_cc4_includes.py script with any changes you would like (starts at line 57 in the new file, on the right).

sarahpearson commented 4 years ago

Ah, I understand now. The formatting as used in the footer (that we include manually when we create a new translation) is the one which reflects input from the team. So we should use that as the canonical. By my review, it looks like the only changes needed are to Bahasa Indonesia, te reo Maori, and portugues.

TimidRobot commented 4 years ago

Ah, I understand now. The formatting as used in the footer (that we include manually when we create a new translation) is the one which reflects input from the team. So we should use that as the canonical. By my review, it looks like the only changes needed are to Bahasa Indonesia, te reo Maori, and portugues.

@sarahpearson: Updated in https://github.com/creativecommons/creativecommons.org/pull/1072/commits/66f938264b23bbab2ee7a39c98adb38c54f40614 (changes are live on testing)

TimidRobot commented 4 years ago

deployed