creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
155 stars 201 forks source link

Corrected Korean translation to go live 2020-04-29 #1102

Closed sarahpearson closed 4 years ago

sarahpearson commented 4 years ago

This pull request includes the six corrected Korean 4.0 files. Please merge on April 29 as discussed. If that date becomes a problem, let me know and we will need to make adjustments to the files since this date is documented in the corrections notice.

I am not sure whether this will be resolved automatically when this is merged, but currently the link to Korean (한국어) at the bottom of each language redirects to the English.

Thanks!

Testing (Staged) Links

TimidRobot commented 4 years ago

I am not sure whether this will be resolved automatically when this is merged, but currently the link to Korean (한국어) at the bottom of each language redirects to the English.

The following redirects will need to be removed as part of this:

creativecommons/sre-salt-prime:states/apache2/files/ccengine.conf: Lines 109-117

    # Legalcode (static HTML): mitigation via REDIRECT
    # TEMPORARILY redirect Korean translations to English
    RewriteRule ^/licenses/by/4.0/legalcode.ko        https://%{HTTP_HOST}/licenses/by/4.0/legalcode [L,R=307]
    RewriteRule ^/licenses/by-sa/4.0/legalcode.ko     https://%{HTTP_HOST}/licenses/by-sa/4.0/legalcode [L,R=307]
    RewriteRule ^/licenses/by-nd/4.0/legalcode.ko     https://%{HTTP_HOST}/licenses/by-nd/4.0/legalcode [L,R=307]
    RewriteRule ^/licenses/by-nc/4.0/legalcode.ko     https://%{HTTP_HOST}/licenses/by-nc/4.0/legalcode [L,R=307]
    RewriteRule ^/licenses/by-nc-sa/4.0/legalcode.ko  https://%{HTTP_HOST}/licenses/by-nc-sa/4.0/legalcode [L,R=307]
    RewriteRule ^/licenses/by-nc-nd/4.0/legalcode.ko  https://%{HTTP_HOST}/licenses/by-nc-nd/4.0/legalcode [L,R=307]
sarahpearson commented 4 years ago

It appears that the header and footer are now appearing twice on each file.

TimidRobot commented 4 years ago

It appears that the header and footer are now appearing twice on each file.

these issues should be resolved

TimidRobot commented 4 years ago

deployed