search

creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
155 stars 201 forks source link

Deeds & Choosers Polish translation contains faulty language assumption for legalcode links #1106

Closed peterspdx closed 4 years ago

peterspdx commented 4 years ago

Describe the bug

On the Polish CC BY 3.0 Poland deed page (Creative Commons — Uznanie autorstwa 3.0 Polska — CC BY 3.0 PL), there is a link attached to the word “licencja” which leads to the following non-working (HTTP/1.1 404 Not Found) URL: https://creativecommons.org/licenses/by/3.0/pl/legalcode.pl

It seems that the proper link should be: https://creativecommons.org/licenses/by/3.0/pl/legalcode

This issue exists for all versions of the CC 3.0 deed

To Reproduce

Visit link above

Expected behavior

Link goes to correct resource

Additional context

Submitted by A.Tarkowski. @kgodey

tarkowski commented 4 years ago

Hi, what is the typical time to fix this sort of bug? I'm asking because I signalled this issue to Diane (thank you @peterspdx for submitting the ticket) - upon request from the Polish Ministry of Digital Affairs which uses CC licenses across the Polish gov.pl public administration service and sees the faulty link as a critical issue. I hope that this can be fixed relatively quickly, thank you!

TimidRobot commented 4 years ago

@tarkowski thank you for the additional context. This is currently at the top of my queue and I hope to resolve it today (Los Angeles/Pacific Time)

TimidRobot commented 4 years ago

Unfortunately, I was able to verify that this issue was not caused by the 2020-04-09 ccEngine infrastructure change and has been around far longer than that.

TimidRobot commented 4 years ago

The issue can not be solved with a simple redirect as some ported legalcode is translated and some is not. For example, Creative Commons — Reconocimiento 3.0 España — CC BY 3.0 ES links to ported legalcode in multiple languages.

TimidRobot commented 4 years ago

I updated the Creative Commons Deeds & Chooser Polish translation in Transifex. The changes have been applied to production and are represented in the following commits:

This "fix" partially breaks the 4.0 deed. The 4.0 deed now links to the English legalcode instead of the Polish legalcode. However, the "fix" is still an improvement. The 2.x and 3.x ports are unique legal documents and the link from the deed must not be a HTTP/1.1 404 Not Found. The 4.0 English legalcode is less helpful, but still legally relevant to Polish speakers. I will open a new Issue to document the larger problem of how ccEngine handles the links between deeds and legalcode across different versions of the licenses.