creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
156 stars 204 forks source link

partially fix layout / html formatting of BY*ND Dutch translations #1160

Closed TimidRobot closed 3 years ago

TimidRobot commented 4 years ago

Fixes

Fixes #1159

Description

Technical details

Tests

BY* 4.0 production BY* 4.0 testing
by-nc-nd (nl) current by-nc-nd (nl) proposed
by-nc-sa (nl) current by-nc-sa (nl) proposed
by-nc (nl) current by-nc (nl) proposed
by-nd (nl) current by-nd (nl) proposed
by-sa (nl) current by-sa (nl) proposed
by (nl) current by (nl) proposed
by-nc-nd (en) current
by-nd (en) current

Screenshots

Current

Screen Shot 2020-09-24 at 09 14 59

Proposed

Screen Shot 2020-09-24 at 09 14 51

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
sarahpearson commented 4 years ago

@mzeinstra Can you take a look at this to make sure it is okay?

mzeinstra commented 4 years ago

@TimidRobot @sarahpearson Yes this is a good fix, to bad that we didn't see this sooner. Thanks for spotting it!

sarahpearson commented 3 years ago

@TimidRobot here is the translated language from the team:

Een fout in deze vertaling is aangepast op [NUMERICAL DATE].

One wrinkle is that we have one other small correction pending in the Dutch files. The diff is here: https://github.com/creativecommons/creativecommons.org/compare/cc4-nl-legalcode.

Can we include both of these corrections in this update @TimidRobot?

TimidRobot commented 3 years ago

One wrinkle is that we have one other small correction pending in the Dutch files. The diff is here: https://github.com/creativecommons/creativecommons.org/compare/cc4-nl-legalcode.

Can we include both of these corrections in this update @TimidRobot?

Those changes have been merged into this branch.

TimidRobot commented 3 years ago

deployed to production