creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
155 stars 201 forks source link

fix donate redirect #1192

Closed TimidRobot closed 3 years ago

TimidRobot commented 3 years ago

Fixes

Fixes #1191 by @zackkrida

Description

fix donation redirect (do not URL escape destination)

Tests

change is live on server and verified:

http -h https://creativecommons.org/donate
HTTP/1.1 301 Moved Permanently
Age: 0
CF-Cache-Status: DYNAMIC
CF-RAY: 5fc60873d8fe35fe-LAX
Connection: keep-alive
Content-Type: text/html; charset=iso-8859-1
Date: Fri, 04 Dec 2020 13:56:50 GMT
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Location: https://classy.org/give/313412/#!/donation/checkout
Server: cloudflare
Set-Cookie: __cfduid=dedb953acd15aaf0288b3a750ae91c5921607090209; expires=Sun, 03-Jan-21 13:56:49 GMT; path=/; domain=.creativecommons.org; HttpOnly; SameSite=Lax
Strict-Transport-Security: max-age=15768000
Transfer-Encoding: chunked
Via: 1.1 varnish (Varnish/5.0)
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Varnish: 363353892
X-XSS-Protection: 1; mode=block
cf-request-id: 06cfa39c69000035fe18999000000001

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [x] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```