TimidRobot
commented
2 years ago @jodeebrowm thank you for taking the time to do this work!! I agree that there should be consistency between formats.
However, I am going to close this pull request because:
- We have to be very careful about changing plain text versions because the already published text is used by software to identify licenses: licensee/licensee (linked from Detecting a license - Licensing a repository - GitHub Docs)
- These files are a legacy system that will be soon replaced by creativecommons/cc-legal-tools-app. That new system will eventually automatically generate plain text legal code files.
Please let me know if:
you'd like to open an issue in creativecommons/cc-legal-tools-app noting the inconsistencyor I can create an issue and credit you in the description
I moved issue to new repo https://github.com/creativecommons/cc-legal-tools-app/issues/286
Fixes
Fixes creativecommons/cc-legal-tools-app#286 by @jodeebrowm
Description
Capitalise the letters used in the items of third level enumerations, e.g. (a)(1)(B) instead of (a)(1)(b). This is consistent with the HTML version of the licenses and only affects the labels of the enumeration not the references inside the text (which are already upper case).
Checklist
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added or updated tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [ ] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of OriginFor the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```